<html>
<head><meta charset="utf-8"><title>vecdeque_make_contiguous · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html">vecdeque_make_contiguous</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="203009156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/203009156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#203009156">(Jul 06 2020 at 16:12)</a>:</h4>
<p>I needed that <a href="https://github.com/rust-lang/rust/issues/70929">https://github.com/rust-lang/rust/issues/70929</a>, and figured I'd take a stab at pushing it through to stabilization. Given that it wasn't based on an RFC, I'm not quite sure what to put in a stabilization report. What are the best next steps for this?</p>



<a name="203009396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/203009396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#203009396">(Jul 06 2020 at 16:14)</a>:</h4>
<p>I'll add that it seems like my crate is one of only two that use the feature, so I don't know if that's enough grounds to stabilize? I'm not sure what the requirements are: <a href="https://github.com/search?q=make_contiguous+-path%3Asrc%2Fliballoc%2F+language%3Arust&amp;type=Code">https://github.com/search?q=make_contiguous+-path%3Asrc%2Fliballoc%2F+language%3Arust&amp;type=Code</a></p>



<a name="204419520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/204419520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#204419520">(Jul 20 2020 at 13:07)</a>:</h4>
<p>Sorry if this isn't the right thing to do, but I was told to ask <span class="user-group-mention" data-user-group-id="2645">@T-libs</span> over in the tracking issue. This feature landed back in early April — what would you want to see before it is stabilized?</p>



<a name="204421749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/204421749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#204421749">(Jul 20 2020 at 13:28)</a>:</h4>
<p><span class="user-mention" data-user-id="120054">@Jon Gjengset</span> Just post a stabilization PR and I'll start an FCP on it. I think that this function is pretty uncontroversial.</p>



<a name="204425451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/204425451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#204425451">(Jul 20 2020 at 14:01)</a>:</h4>
<p><span class="user-mention" data-user-id="143274">@Amanieu</span> Thanks! Done in <a href="https://github.com/rust-lang/rust/pull/74559">https://github.com/rust-lang/rust/pull/74559</a>.</p>



<a name="206688920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/206688920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#206688920">(Aug 12 2020 at 12:49)</a>:</h4>
<p><span class="user-mention" data-user-id="143274">@Amanieu</span> Not sure what the next thing is for <a href="https://github.com/rust-lang/rust/pull/74559">https://github.com/rust-lang/rust/pull/74559</a>. I'd really like to see it land in time to make the next beta. Do you think it is worthwhile to ping the relevant people here? I realize everything is also a bit thrown out-of-whack with the recent Mozilla layoffs.</p>



<a name="206692877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/206692877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#206692877">(Aug 12 2020 at 13:26)</a>:</h4>
<p><span class="user-mention" data-user-id="120054">@Jon Gjengset</span> I think it's fine to ping the people who haven't filled their checkboxes.</p>



<a name="206694398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/206694398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#206694398">(Aug 12 2020 at 13:39)</a>:</h4>
<p>Do you think it's best to ping them again in the PR or here instead?</p>



<a name="206767704"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/206767704" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#206767704">(Aug 12 2020 at 23:55)</a>:</h4>
<p>they were already pinged 6 days back, so not sure a 2nd ping would have much value <span aria-label="grinning" class="emoji emoji-1f600" role="img" title="grinning">:grinning:</span></p>



<a name="206809168"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/206809168" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#206809168">(Aug 13 2020 at 12:36)</a>:</h4>
<p>Fair enough — I guess I'm just curious whether it's that they've decided they're skeptical about approving (but haven't said anything), or whether they just haven't gotten around to looking at it yet.</p>



<a name="206809728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/206809728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#206809728">(Aug 13 2020 at 12:42)</a>:</h4>
<p>i think it's the latter, generally if someone has any objections to a fcp - they will comment on it later so that the fcp gets blocked on it</p>



<a name="207628743"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/207628743" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#207628743">(Aug 21 2020 at 12:35)</a>:</h4>
<p>It's now been two weeks since the last ping, and if I'm reading <a href="https://forge.rust-lang.org/">https://forge.rust-lang.org/</a> right, we're coming up on the merge window for the next release. Do you think another ping is warranted <span class="user-mention" data-user-id="120823">@DPC</span> <span class="user-mention" data-user-id="143274">@Amanieu</span> ?</p>



<a name="207631943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/207631943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#207631943">(Aug 21 2020 at 13:11)</a>:</h4>
<p>Yes</p>



<a name="207633746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/207633746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#207633746">(Aug 21 2020 at 13:28)</a>:</h4>
<p>I pinged them in the PR again ;)</p>



<a name="207638516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/207638516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#207638516">(Aug 21 2020 at 14:12)</a>:</h4>
<p>maybe <span class="user-mention" data-user-id="116122">@simulacrum</span> can help us solve this issue <span aria-label="grinning" class="emoji emoji-1f600" role="img" title="grinning">:grinning:</span></p>



<a name="207638642"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/207638642" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#207638642">(Aug 21 2020 at 14:13)</a>:</h4>
<p>yeah pinging seems like the best idea, I can't suggest anything else. Maybe pinging in Zulip vs github could be better.</p>



<a name="207645933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/vecdeque_make_contiguous/near/207645933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/vecdeque_make_contiguous.html#207645933">(Aug 21 2020 at 15:13)</a>:</h4>
<p>I'll try pinging one reviewer at random here too then. Hopefully this doesn't count as too much noise <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span><br>
<span class="user-mention" data-user-id="243558">@Steven Fackler</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>